ppc64le-cloud / test-infra

Apache License 2.0
6 stars 20 forks source link

Update all-in-one image for master go k8s build job #403

Closed Rajalakshmi-Girish closed 1 year ago

Rajalakshmi-Girish commented 1 year ago

Task: https://jsw.ibm.com/browse/POWERCLOUD-67

Explicitly setting CGO_ENABLED=0 as a temporary solution. Will debug and understand why k8s Upstream is not taking care of this. Looks as it is a change from go1.20, https://github.com/kubernetes/kubernetes/blob/master/hack/lib/golang.sh needs some modification. Ref: https://go.dev/doc/go1.20#go-command

ppc64le-cloud-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, Rajalakshmi-Girish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/ppc64le-cloud/test-infra/blob/master/OWNERS)~~ [mkumatag] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ppc64le-cloud-bot commented 1 year ago

@Rajalakshmi-Girish: Updated the job-config configmap in namespace prow at cluster default using the following files:

In response to [this](https://github.com/ppc64le-cloud/test-infra/pull/403): >Task: https://jsw.ibm.com/browse/POWERCLOUD-67 > >Explicitly setting `CGO_ENABLED=0` as a temporary solution. >Will debug and understand why k8s Upstream is not taking care of this. >Looks as it is a change from go1.20, https://github.com/kubernetes/kubernetes/blob/master/hack/lib/golang.sh needs some modification. >Ref: https://go.dev/doc/go1.20#go-command Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.