search

ppc64le-cloud / test-infra

Apache License 2.0
6 stars 19 forks source link

Use image SHA along with name as a good practice #413

Closed AshwinHIBM closed 1 year ago

AshwinHIBM commented 1 year ago

For the Docker postsubmit jobs, we currently only specify the image name, which defaults to the image tagged "latest". Specifying the hash is a safer practice. The hash specified corresponds to the newly built and locally tested 0.7-ppc64le image available here: https://quay.io/repository/powercloud/docker-ce-build

ppc64le-cloud-bot commented 1 year ago

Hi @AshwinHIBM. Thanks for your PR.

I'm waiting for a ppc64le-cloud member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ppc64le-cloud-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AshwinHIBM, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/ppc64le-cloud/test-infra/blob/master/OWNERS)~~ [mkumatag] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ppc64le-cloud-bot commented 1 year ago

@AshwinHIBM: Updated the job-config configmap in namespace prow at cluster default using the following files:

In response to [this](https://github.com/ppc64le-cloud/test-infra/pull/413): >For the Docker postsubmit jobs, we currently only specify the image name, which defaults to the image tagged "latest". Specifying the hash is a safer practice. The hash specified corresponds to the newly built and locally tested 0.7-ppc64le image available here: https://quay.io/repository/powercloud/docker-ce-build Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.