search

ppc64le-cloud / test-infra

Apache License 2.0
6 stars 20 forks source link

Remove ginko tester flags from k8s conformance job #438

Closed Rajalakshmi-Girish closed 9 months ago

Rajalakshmi-Girish commented 9 months ago

After the change https://github.com/kubernetes-sigs/kubetest2/pull/251, the flags --flake-attempts and --test-package-bucket don't exist with kubetest2's ginkgo tester.

As the download is from dl.k8s.io and not GCS bucket, the bucket name is not needed. Also, as per k8s policy, retry of flaking is not encouraged. Hence removing that flag too.

Below is the test run done with this change: https://prow.ppc64le-cloud.cis.ibm.net/job-history/gs/ppc64le-kubernetes/logs/test-periodic-kubernetes-containerd-conformance-test-ppc64le

ppc64le-cloud-bot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, Rajalakshmi-Girish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/ppc64le-cloud/test-infra/blob/master/OWNERS)~~ [mkumatag] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ppc64le-cloud-bot commented 9 months ago

@Rajalakshmi-Girish: Updated the job-config configmap in namespace prow at cluster default using the following files:

In response to [this](https://github.com/ppc64le-cloud/test-infra/pull/438): >After the change https://github.com/kubernetes-sigs/kubetest2/pull/251, the flags `--flake-attempts` and `--test-package-bucket` don't exist with kubetest2's ginkgo tester. > >As the download is from dl.k8s.io and not GCS bucket, the bucket name is not needed. >Also, as per k8s policy, retry of flaking is not encouraged. Hence removing that flag too. > >Below is the test run done with this change: >https://prow.ppc64le-cloud.cis.ibm.net/job-history/gs/ppc64le-kubernetes/logs/test-periodic-kubernetes-containerd-conformance-test-ppc64le Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.