ppc64le-cloud / test-infra

Apache License 2.0
6 stars 20 forks source link

Change checkconfig command in pull-test-infra-prow-checkconfig job #446

Closed Rajalakshmi-Girish closed 7 months ago

Rajalakshmi-Girish commented 7 months ago

The presubmit job for https://github.com/ppc64le-cloud/test-infra/pull/444 still fails with below error:

could not start the process: fork/exec /checkconfig: no such file or directory

This change is required after the image tag upgrade.

Have verified this manually by creating a container and also had a look at the upstream job https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/test-infra/test-infra-presubmits.yaml#L75

[root@maxwells1 ~]# kubectl describe pod checkconfig2 | grep image
  Normal  Pulling    8m23s  kubelet            Pulling image "gcr.io/k8s-prow/checkconfig:v20240205-8f023a0da6"
  Normal  Pulled     8m22s  kubelet            Successfully pulled image "gcr.io/k8s-prow/checkconfig:v20240205-8f023a0da6" in 1.834609537s (1.834623899s including waiting)
[root@maxwells1 ~]# kubectl exec -it checkconfig2 -- /bin/sh
/ # /checkconfig version
/bin/sh: /checkconfig: not found
/ # checkconfig version
{"component":"checkconfig","file":"k8s.io/test-infra/prow/cmd/checkconfig/main.go:240","func":"main.main","level":"fatal","msg":"Error parsing options - invalid options: --config-path is mandatory","severity":"fatal","time":"2024-02-08T07:57:09Z"}
/ #
Rajalakshmi-Girish commented 7 months ago

@Rajalakshmi-Girish: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests: Test name Commit Details Required Rerun command pull-test-infra-prow-checkconfig c0f46a2 link true /test pull-test-infra-prow-checkconfig

Full PR test history. Your PR dashboard.

@mkumatag This change should have been part of image tag upgrade by https://github.com/ppc64le-cloud/test-infra/pull/446 Hmm does this mean, I should update the job in prow infra from backend!

ppc64le-cloud-bot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, Rajalakshmi-Girish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/ppc64le-cloud/test-infra/blob/master/OWNERS)~~ [mkumatag] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mkumatag commented 7 months ago

/test pull-test-infra-prow-checkconfig

Rajalakshmi-Girish commented 7 months ago

/test pull-test-infra-prow-checkconfig

It is picking up the job that is currently existing. Maybe I should update job-config from the back end?

mkumatag commented 7 months ago

@Rajalakshmi-Girish lets make this change in the backend and rerun the job

Rajalakshmi-Girish commented 7 months ago

/test pull-test-infra-prow-checkconfig

ppc64le-cloud-bot commented 7 months ago

@Rajalakshmi-Girish: Updated the job-config configmap in namespace prow at cluster default using the following files:

In response to [this](https://github.com/ppc64le-cloud/test-infra/pull/446): >The presubmit job for https://github.com/ppc64le-cloud/test-infra/pull/444 still fails with below error: >``` >could not start the process: fork/exec /checkconfig: no such file or directory >``` >This change is required after the image tag upgrade. > >Have verified this manually by creating a container and also had a look at the upstream job https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/test-infra/test-infra-presubmits.yaml#L75 > >``` >[root@maxwells1 ~]# kubectl describe pod checkconfig2 | grep image > Normal Pulling 8m23s kubelet Pulling image "gcr.io/k8s-prow/checkconfig:v20240205-8f023a0da6" > Normal Pulled 8m22s kubelet Successfully pulled image "gcr.io/k8s-prow/checkconfig:v20240205-8f023a0da6" in 1.834609537s (1.834623899s including waiting) >[root@maxwells1 ~]# kubectl exec -it checkconfig2 -- /bin/sh >/ # /checkconfig version >/bin/sh: /checkconfig: not found >/ # checkconfig version >{"component":"checkconfig","file":"k8s.io/test-infra/prow/cmd/checkconfig/main.go:240","func":"main.main","level":"fatal","msg":"Error parsing options - invalid options: --config-path is mandatory","severity":"fatal","time":"2024-02-08T07:57:09Z"} >/ # >``` Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.