search

ppc64le-cloud / test-infra

Apache License 2.0
6 stars 20 forks source link

Skip the TestWatchDelay UT based on suggestion from etcd #451

Closed Rajalakshmi-Girish closed 6 months ago

Rajalakshmi-Girish commented 6 months ago

Below UTs have been flaking for many days on both the etcd jobs in our CI - postsubmit-master-golang-etcd-build-test-ppc64le and periodic-etcd-test-ppc64le

As per the comment here in issue https://github.com/etcd-io/etcd/issues/16319#issuecomment-1961604393, disabling it in our CI seems to be the solution.

Have made sure that this change is really skipping the tests by doing a test-pj. https://prow.ppc64le-cloud.cis.ibm.net/view/gs/ppc64le-kubernetes/logs/test-periodic-etcd-test-ppc64le/1762434764733681664 is the link where tests from https://github.com/etcd-io/etcd/blob/main/tests/e2e/watch_delay_test.go are not appearing.

ppc64le-cloud-bot commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Rajalakshmi-Girish Once this PR has been reviewed and has the lgtm label, please assign mkumatag for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/ppc64le-cloud/test-infra/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mkumatag commented 6 months ago

I really don't know what do you mean by low performance hardware, I feel we should spend more time to find why this test is taking more time in ppc64le environment?

Rajalakshmi-Girish commented 6 months ago

I really don't know what do you mean by low performance hardware, I feel we should spend more time to find why this test is taking more time in ppc64le environment?

This test flakes even on x86_64 (ran in a VM on Fyre). Just that it isn't seen in their CI! Will try to understand more about this.

Rajalakshmi-Girish commented 6 months ago

I really don't know what do you mean by low performance hardware, I feel we should spend more time to find why this test is taking more time in ppc64le environment?

https://github.com/ppc64le-cloud/test-infra/pull/452 could be the reason for flakiness :|