search

ppc64le-cloud / test-infra

Apache License 2.0
6 stars 20 forks source link

Correct the indentation typo with resource requests #452

Closed Rajalakshmi-Girish closed 6 months ago

Rajalakshmi-Girish commented 6 months ago

The indentation was wrong for resources metadata in jobs test-e2e-capi-ibmcloud-periodics.yaml, test-etcd-periodics.yaml and etcd-postsubmit.yaml, and hence no proper resources were allocated to the jobs. I see the TestWatchDelay related flakiness improve to a major extent after proper resource allotment.

ppc64le-cloud-bot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, Rajalakshmi-Girish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/ppc64le-cloud/test-infra/blob/master/OWNERS)~~ [mkumatag] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mkumatag commented 6 months ago

/lgtm

ppc64le-cloud-bot commented 6 months ago

@Rajalakshmi-Girish: Updated the job-config configmap in namespace prow at cluster default using the following files:

In response to [this](https://github.com/ppc64le-cloud/test-infra/pull/452): >The indentation was wrong for resources metadata in jobs `test-e2e-capi-ibmcloud-periodics.yaml`, `test-etcd-periodics.yaml` and `etcd-postsubmit.yaml`, and hence no proper resources were allocated to the jobs. >I see the `TestWatchDelay` related flakiness improve to a major extent after proper resource allotment. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mkumatag commented 6 months ago

@Rajalakshmi-Girish lets think about how to avoid such issues in the feature, can we add some linting to catch such issues? not sure if there is a way..

Rajalakshmi-Girish commented 6 months ago

I'm not sure about this, will it make any difference when we just have a key without requests.. cc @Karthik-K-N

anyways this is a invalid syntax which needs a fix, hence merging.

All these days, etcd job has been sending only resources: {} in job yaml due to this invalid syntax.

When I tested etcd flakes locally as well, most of the time the host had resource limitations. Running the long pending TestWatchDelay flake on a pod with required resources, displayed 0 failure for 30m of stress run. @mkumatag @srivastav-abhishek