ppc64le-cloud / test-infra

Apache License 2.0
6 stars 20 forks source link

Add GOPPC64 env avriable to go building jobs #458

Closed Rajalakshmi-Girish closed 6 months ago

Rajalakshmi-Girish commented 6 months ago

@mkumatag I have verified if the value is being picked up while binary building by running a few jobs by doing strings <binary_name> | grep GOPPC

Also have checked in a couple of runs if the removal of PATH export is not creating any failure. Any idea why we had to include these PATH exports inspite of having these values set in all-in-one image from the beginning?

ppc64le-cloud-bot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, Rajalakshmi-Girish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[config/OWNERS](https://github.com/ppc64le-cloud/test-infra/blob/master/config/OWNERS)~~ [Rajalakshmi-Girish,mkumatag] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ppc64le-cloud-bot commented 6 months ago

@Rajalakshmi-Girish: Updated the following 2 configmaps:

In response to [this](https://github.com/ppc64le-cloud/test-infra/pull/458): >- Have added a preset label to enable the environment variable `GOPPC64=power9` for all the go binary building jobs. > > 1. periodic-golang-master-build-ppc64le > 2. postsubmit-kubernetes-build-golang-master-ppc64le > 3. postsubmit-master-golang-kubernetes-unit-test-ppc64le > 4. postsubmit-os-kubernetes-build-golang-master-ppc64le > 5. postsubmit-os-origin-build-golang-master-ppc64le > 6. postsubmit-master-golang-etcd-build-test-ppc64le > 7. periodic-etcd-test-ppc64le > 8. periodic-kubernetes-unit-test-ppc64le > 9. periodic-kubernetes-containerd-e2e-node-tests-ppc64le > >- Also have removed the export of the PATH variable to add `/usr/local/go/bin` and `$GOPATH/bin` to the PATH value. As the `all-in-one:0.6` image has these values already added to PATH. > - https://github.com/ppc64le-cloud/test-infra/blob/master/images/all-in-one/Dockerfile#L47 > - https://github.com/ppc64le-cloud/test-infra/blob/master/images/all-in-one/Dockerfile#L113 > >@mkumatag I have verified if the value is being picked up while binary building by running a few jobs by doing `strings | grep GOPPC` > >Also have checked in a couple of runs if the removal of PATH export is not creating any failure. Any idea why we had to include these PATH exports inspite of having these values set in `all-in-one` image from the beginning? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.