search

ppc64le-cloud / test-infra

Apache License 2.0
6 stars 20 forks source link

Disable errexit before kubetest2 tf command #469

Closed Rajalakshmi-Girish closed 3 months ago

Rajalakshmi-Girish commented 3 months ago

This change is to make sure the --down flag of kubetest2 tf runs inspite of failure in the --up or --test phases. https://prow.ppc64le-cloud.cis.ibm.net/view/s3/ppc64le-prow-logs/logs/test-postsubmit-master-golang-kubernetes-conformance-test-ppc64le/1793562341929914368 is the test job that was successful with this change.

ppc64le-cloud-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, Rajalakshmi-Girish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[config/OWNERS](https://github.com/ppc64le-cloud/test-infra/blob/master/config/OWNERS)~~ [Rajalakshmi-Girish,mkumatag] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ppc64le-cloud-bot commented 3 months ago

@Rajalakshmi-Girish: Updated the job-config configmap in namespace prow at cluster default using the following files:

In response to [this](https://github.com/ppc64le-cloud/test-infra/pull/469): >This change is to make sure the `--down` flag of `kubetest2 tf` runs inspite of failure in the `--up` or `--test` phases. >https://prow.ppc64le-cloud.cis.ibm.net/view/s3/ppc64le-prow-logs/logs/test-postsubmit-master-golang-kubernetes-conformance-test-ppc64le/1793562341929914368 is the test job that was successful with this change. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.