search

ppc64le-cloud / test-infra

Apache License 2.0
6 stars 20 forks source link

Label Docker integration test CR YAMLs #472

Closed AshwinHIBM closed 3 months ago

AshwinHIBM commented 3 months ago

pj.yaml sets the environment variable S3_SECRET_AUTH only if the jobs are labelled with preset-build-docker: "true". We need to export logs for debugging from these CI jobs to the COS bucket. Label the jobs so they can read ${S3_SECRET_AUTH}

ppc64le-cloud-bot commented 3 months ago

Hi @AshwinHIBM. Thanks for your PR.

I'm waiting for a ppc64le-cloud member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ppc64le-cloud-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AshwinHIBM, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[config/OWNERS](https://github.com/ppc64le-cloud/test-infra/blob/master/config/OWNERS)~~ [mkumatag] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ppc64le-cloud-bot commented 3 months ago

@AshwinHIBM: Updated the job-config configmap in namespace prow at cluster default using the following files:

In response to [this](https://github.com/ppc64le-cloud/test-infra/pull/472): >pj.yaml sets the environment variable `S3_SECRET_AUTH` only if the jobs are labelled with `preset-build-docker: "true"`. We need to export logs for debugging from these CI jobs to the COS bucket. Label the jobs so they can read `${S3_SECRET_AUTH}` Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.