Milvus 2.4.11 Script, patch and Dockerfile

ppc64le / build-scripts

Build scripts for open source projects on Linux on POWER LE

Apache License 2.0

77 stars 235 forks source link

Milvus 2.4.11 Script, patch and Dockerfile #4518

Closed sumitd2 closed 3 days ago

sumitd2 commented 4 days ago

Checklist

[X] Have you checked and followed all the points mention in the CONTRIBUTING.MD
[X] Have you validated script on UBI 9 container
[X] Did you run the script(s) on fresh container with set -e option enabled and observe success ?
[X] Did you have Legal approvals for patch files ?

sumitd2 commented 3 days ago

in general, for any dependencies being install from source, we need to start putting some additional error handling to ensure that the version being built (for example for python , golang etc.) is not already installed, this is to support some upcoming changes in currency

Okay, but in that case script will have to be tested in that kind of an environment, which would open a can of worms. As you know we only test in a fresh docker container to keep things simple enough.

seth-priya commented 3 days ago

in general, for any dependencies being install from source, we need to start putting some additional error handling to ensure that the version being built (for example for python , golang etc.) is not already installed, this is to support some upcoming changes in currency

Okay, but in that case script will have to be tested in that kind of an environment, which would open a can of worms. As you know we only test in a fresh docker container to keep things simple enough.

Yes, think of it as an extension built on top of the existing scripts and doing some pre/post processing.