ppc64le / charts

Helm Charts for ISV and Open Source apps for Kubernetes and IBM Cloud Private
Apache License 2.0
5 stars 5 forks source link

Fixed CV 1.0.4 Warnings and Errors + Issues with README and Icon #19

Closed lysannef closed 5 years ago

lysannef commented 5 years ago

Hi @brucesemple ,

Following are the changes made to the charts included in this PR :

             1) Removed the ## TL;DR; from README.md files of all charts.

            2) Add icons to ppc64le/charts/logo folder. 

            3) Add icon field to chart.yaml file of charts in the form of : (icon: https://raw.githubusercontent.com/ppc64le/charts/master/logo/*) 
               pointing to the relative path to the ppc64le/charts/logo folder

            4) Changed Prerequisites in README.md file to the following :
                                            - Kubernetes 1.7+ 
                                            - Tiller 2.7.2 or later

            5) Added Affinity template file to ibm-*/templates folder.

            6) Changed the affinity value in deployment.yaml/statefulset files of every chart to  reflect 'nodeaffinity' defined in the new _affinity.tpl file.

            7) Added an extra parameter 'node' to every values.yaml file to select the architecture of the node the chart has to be deployed on.
                Also added corresponding dropdown options to values-metadata.yaml.

            8) Changed the image configuration data in README.md to reflect the specific power image being used in the chart, as a default.

            9)  Fixed CV Warnings + Errors based on CV Tool v 1.0.4 for all charts ( includes things like changing to camelCase, parameters used but not defined in values.yaml)

            10) After applying the CV Warning + Error fixes have validated the charts by deploying them through the UI and through helm cli .
                   The pods of the deployment show up in running state.

            11)  Changed the post deployment instruction in _helpers.tpl to :
                   export NODE_IP=$(kubectl get nodes --namespace {{ .Release.Namespace }} -o jsonpath=" 
                    {.items[0].status.addresses[1].address}") in charts:
                           ibm-adminer
                           ibm-glassfish
            12) Added Note in readme for specifying the chart is validated on ppc64le.

Kindly review.

Thanks, Lysanne Fernandes

ghatwala commented 5 years ago

@brucesemple - could you please review ?

brucesemple commented 5 years ago

CV lint is a tougher (and more thorougher) reviewer than I -- If you passed that .. you are good to go! Thanks for all your hard work -- I know it's been painful!