search

pperle / PoGoIV_xposed

Xposed module that displays pokémon IV's
MIT License
42 stars 14 forks source link

Add Moves translation #10

Open Teelve opened 8 years ago

Teelve commented 8 years ago

You translated pokemon names, okay fine, but you should translate moves aswell, way more useful ;)

pperle commented 8 years ago

There are about 300 moves ... https://github.com/chuparCh0pper/PoGoIV_xposed/blob/master/app/src/main/java/com/github/aeonlucid/pogoprotos/Enums.java#L870

You can start translating if you want ;)

Xelwon commented 8 years ago

I made a java class to can translate all movements easily. you only need put getMovement(Languages.[your_language], [string id]) for example: getMovement(Languages.ENGLISH, 10);

EDIT: I changed the attached file for another more recient file. PogoMovements.txt

pperle commented 8 years ago

@Xelwon thank you for your work. While implementing your solution I realized that the order of the moves do not match up. The first move on bulbapedia is "Pound" but the first one in pokémon go is "THUNDER_SHOCK".

Xelwon commented 8 years ago

OMG, I will try a quick reordering using pokemon go ids

EDIT: Done. This new version, changes Pokemon go IDs to Bulbapedia IDs. PogoMovements.txt

pperle commented 7 years ago

@Xelwon sorry I did not see your edit until now. I will try to merge it tomorrow.