pperle / PoGoIV_xposed

Xposed module that displays pokémon IV's
MIT License
42 stars 14 forks source link

[Suggestion] Auto Detect "Bubblestrat" Compatible Pokemons #18

Open jane0815 opened 8 years ago

jane0815 commented 8 years ago

It would be great if the module could auto detect pokemons that are suitbale for Bubblestrat: https://pokemongo.gamepress.gg/bubblestrat-possibilities

Bubblestrat Pokemons must have the right Type, Level, Moveset and IVs so it is not easy to find them.

A "warning Message" that the pokemon is compatible would be very usefull and prevent from recycling it.

pperle commented 8 years ago

Bubblestrat Pokemons must have the right Type, Level, Moveset and IVs so it is not easy to find them.

Looking at https://pokemongo.gamepress.gg/bubblestrat-possibilities IVs are not important.

So when you encounter a Horsea with Bubble you want a Toast saying something like "This pokémon youd be used as a defender for BubbleStrat."?

jane0815 commented 8 years ago

I got the info that IVs are important too here: http://pokemongo.gamepress.gg/bubblestrat

First, you need a Diglett. This Diglett has to be caught at Level 1. All Level 1 Digletts will be caught at 10CP. At this point, you will need to power it up once, bringing it to what we call “Level 1.5.” The Level 1.5 Diglett will need to remain 10CP. If he is 11CP, his IVs are too high to use the tactic (and you won’t know this until you actually power him up once). Now, once you’ve got your 10CP Level 1.5 Diglett, he still isn’t guaranteed to be useable. The minimum Attack IVs required for the Diglett to do 4 damage per Scratch or 5 damage per Mud Shot (if you’re lucky enough to have a level 1 Mud Shot Diglett lying around) will be determined by the species and defense IVs of your Bubble-using gym defender…

Sounds like IVs are important too. Maybe not for all pokemons that can be used for Bubblestrat.

So when you encounter a Horsea with Bubble you want a Toast saying something like "This pokémon youd be used as a defender for BubbleStrat."?

Exactly! That would be really awesome!!

pperle commented 7 years ago

Please try the latest verion. I just implemented https://github.com/chuparCh0pper/PoGoIV_xposed/commit/645ac7325c1169a1fceed612e376cd20c0c94d84 a BubbleStrat++ checker according to https://pokemongo.gamepress.gg/bubblestrat-possibilities , taking the pokémon and its level into consideration

jane0815 commented 7 years ago

Hi, the latest version i can find in Xposed Installer is 1.4 which i am already currently using. How can i try latest version.

Thx a lot!!

wardsimon commented 7 years ago

Hey,

Just made a little update which also checks move compatibility for defenders. See https://github.com/simonward86/PoGoIV_xposed/commit/785cf8ad9f3cb38d6f72aa5ed4a94b0a9af7c4ec Looking into writing for attackers as well.

jane0815 commented 7 years ago

Still can only find 1.4 in Xposed Installer.

By the way is the module still working for you on 0.37 @simonward86 ?

pperle commented 7 years ago

@simonward86 I merged your code, thank you @jane0815 I just uploaded v.1.5 but it is only compatible with 0.35

wardsimon commented 7 years ago

@jane0815

I've been looking through the 0.37.0 code and have not seen anything which looks promising for hooking. Until we find a substitute for "doSyncRequest" & "readDataSteam" I dont not see any compatibility.

HexDestroyer commented 7 years ago

@simonward86 so, this works in 0.37. https://github.com/ELynx/pokemon-go-xposed-mitm/blob/master/app/src/main/java/com/elynx/pogoxmitm/Injector.java

getOutputStream and getInputStream do work. Just remove the checks "context.niaRequest" and "context.niaResponse".

jane0815 commented 7 years ago

@chuparCh0pper Thx! I will test it out as long as 0.35 is still working and report if it works!

edit: Module installed and working fine so far. Now just need to be lucky to stumble over a BubbleStrat pokemon.

By the way the new functions are awesome! Specially the Candy List is so usefull.

@simonward86 I think @HexDestroyer found a way to dump the IVs in 0.37 to a text file: https://github.com/chuparCh0pper/PoGoIV_xposed/issues/23#issuecomment-246513506

Keep up good work! Love this module!

jane0815 commented 7 years ago

I just catched a l1 Krabby with Bubble Attack but the module did not show a message that it is a BubbleStrat Defender.

The pop-Up showed only the normal infos:

Krabby (WP10) LVL 1.0 51.1% (A/D/S 10/2/11)

Moves: Bubble, Vice Grip

wardsimon commented 7 years ago

@jane0815 I've looked over the code and can't see any obvious errors in the calculation. Were there any errors in the Xposed log?

jane0815 commented 7 years ago

@simonward86 I did not check the log as the pop-up looked normal. I just did but it is not in the log anymore. Next time i will take a look immediately.

wardsimon commented 7 years ago

@jane0815 Just a thought... The notification a toast message, details are not shown in the pop-up. That might be the reason it was missed. I'll have a look at it tomorrow

jane0815 commented 7 years ago

@simonward86 I opened the pop-up after it disappeared/went to drop down menu but it only showed the normal infos.

Krabby (WP10) LVL 1.0 51.1% (A/D/S 10/2/11)

Moves: Bubble, Vice Grip

Capture Probability: Poke Ball: 100.0% Great Ball: 100.0% Ultra Ball: 100.0%