search

ppescher / resizablelib

A set of MFC classes to easily make resizable windows
Other
55 stars 27 forks source link

Partial optimization of code #23

Closed irwir closed 4 years ago

irwir commented 4 years ago

While figuring out implication of the PR #19, it was found that certain parts of the library could be improved. The code in this PR should be slightly faster and smaller (1 KB was shaved off from an application).

  1. Probably you should merge @Blonder's PR before this one to give him credits (as this PR already includes the fix).

  2. It seems that other library classes need no fixes for XP because there were no related style changes.

  3. ResizableComboBox example's solution had the library project as the first entry and thus the startup project.

More points for your consideration (not implemented here).

  1. /EDITANDCONTINUE generates warnings (because of /SAFESEH) and could be removed from all projects.
  2. VS 2019 obsoletes Enable minimal rebuild and outputs warnings. The suggestion is to remove it from all projects.
  3. ResizableSplitterWnd class has size tracking, but it was not used in your MDI example. It would be nice to be added to the demo.
  4. Finally, all examples but one use the name demo.sln - tough to choose in Visual Studio from half a dozen of identical names.
irwir commented 4 years ago

One more point: Copyright (C) 2000-2015 could be updated.