search

ppescher / resizablelib

A set of MFC classes to easily make resizable windows
Other
55 stars 28 forks source link

Test hidden modeless dialog #35

Open ppescher opened 2 months ago

ppescher commented 2 months ago

Address save/restore on a modeless dialog initially hidden, that was incorrectly making it visible during initialization.

Now the restore process is postponed until the dialog is made visible for the first time, preventing the override of the initial hidden state.

See pull request #32 for details. Anyone interested please try this patch also in your own use cases, to confirm it does what it's supposed to and there are no unexpected side-effects.

irwir commented 2 months ago

Moved this comment to the correct PR. The changes so far look good; dialogs with visible initial state behaved as usual.

adipose commented 2 months ago

This fixes the issue for mpc-hc after removal of our custom code.

ppescher commented 2 months ago

Nice! I will propagate this change to the other dialog flavors.

adipose commented 1 month ago

Any chance of this making it to master soon?

I have updated mpc-hc code to take advantage but I would like it to be based on commited code.