ppfeufer / aa-srp

SRP Module for Alliance Auth
GNU General Public License v3.0
2 stars 6 forks source link

[FIX] Kill mail detection from zKillboard's API response. #187

Closed ppfeufer closed 4 months ago

ppfeufer commented 4 months ago

Description

Fixed

Type of change

Checklist:

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 52.66%. Comparing base (ed3c16e) to head (97bda19).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/ppfeufer/aa-srp/pull/187/graphs/tree.svg?width=650&height=150&src=pr&token=D63TU2TBIW&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Pfeufer)](https://app.codecov.io/gh/ppfeufer/aa-srp/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Pfeufer) ```diff @@ Coverage Diff @@ ## master #187 +/- ## ========================================== - Coverage 53.05% 52.66% -0.38% ========================================== Files 21 21 Lines 1216 1225 +9 Branches 100 104 +4 ========================================== Hits 645 645 - Misses 562 571 +9 Partials 9 9 ``` | [Files](https://app.codecov.io/gh/ppfeufer/aa-srp/pull/187?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Pfeufer) | Coverage Δ | | |---|---|---| | [aasrp/views/general.py](https://app.codecov.io/gh/ppfeufer/aa-srp/pull/187?src=pr&el=tree&filepath=aasrp%2Fviews%2Fgeneral.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Pfeufer#diff-YWFzcnAvdmlld3MvZ2VuZXJhbC5weQ==) | `41.55% <20.00%> (-0.40%)` | :arrow_down: | | [aasrp/managers.py](https://app.codecov.io/gh/ppfeufer/aa-srp/pull/187?src=pr&el=tree&filepath=aasrp%2Fmanagers.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Pfeufer#diff-YWFzcnAvbWFuYWdlcnMucHk=) | `39.73% <11.12%> (-4.21%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/ppfeufer/aa-srp/pull/187?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Pfeufer). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Pfeufer) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/ppfeufer/aa-srp/pull/187?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Pfeufer). Last update [ed3c16e...97bda19](https://app.codecov.io/gh/ppfeufer/aa-srp/pull/187?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Pfeufer). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter+Pfeufer).