search

ppinard / matplotlib-colorbar

Provides a new artist for matplotlib to display a colorbar
BSD 2-Clause "Simplified" License
7 stars 3 forks source link

correctly use norm if provided #6

Closed cphyc closed 7 years ago

cphyc commented 7 years ago

Should fix #5 .

cphyc commented 7 years ago

Seems like the expected image is not up-to-date anymore. I attached the version I got example1

ppinard commented 7 years ago

Thank you very much for finding and fixing this bug. I suspect that the test failed initially because of the release of matplotlib 2.0. I am away on business, I will have a final look and merge your pull request in a few days.

cphyc commented 7 years ago

Thanks. I also uploaded a version for python 3.6 so that you can roll-out a release for this version.

ppinard commented 7 years ago

I cleaned up a bit your commit to remove some autoformatting. I think it is better since the diff now highlights the modifications.

ppinard commented 7 years ago

Fix in release 0.3.4. Thank you for your contribution.