ppizarror / pygame-menu

A menu for pygame. Simple, and easy to use
https://pygame-menu.readthedocs.io/
Other
555 stars 141 forks source link

Avoid incorrect warning about title font color and menu background color being equal or similar | #473 #474

Closed DKNorad closed 1 year ago

DKNorad commented 1 year ago

Moved the self._menubar.set_menu(self) after self._menubar.set_font() to avoid running _check_title_color() in menubar.py before a title font color is set.

ppizarror commented 1 year ago

Thanks, I'll merge today

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bcfaccb) 97.22% compared to head (684a83f) 97.24%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #474 +/- ## ========================================== + Coverage 97.22% 97.24% +0.01% ========================================== Files 49 49 Lines 12422 12436 +14 ========================================== + Hits 12077 12093 +16 + Misses 345 343 -2 ``` | [Files](https://app.codecov.io/gh/ppizarror/pygame-menu/pull/474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pablo+Pizarro+R.) | Coverage Δ | | |---|---|---| | [pygame\_menu/menu.py](https://app.codecov.io/gh/ppizarror/pygame-menu/pull/474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pablo+Pizarro+R.#diff-cHlnYW1lX21lbnUvbWVudS5weQ==) | `96.69% <100.00%> (+0.05%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/ppizarror/pygame-menu/pull/474/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pablo+Pizarro+R.)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.