search

ppizarror / pygame-menu

A menu for pygame. Simple, and easy to use
https://pygame-menu.readthedocs.io/
Other
555 stars 141 forks source link

typing (from typing import List > list, etc) #476

Closed JaskRendix closed 10 months ago

JaskRendix commented 10 months ago

PR replaces List with list, Dict with dict, etc. I used isort on pygame_menu/_types.py

ppizarror commented 10 months ago

Hi @JaskRendix. Is there any convention, benefit, etc, to get rid off these base types?

I know I inherited that to support older Python versions (python 3.6, 3.7, 3.8) and to support the sphinx documentation system (which makes https://pygame-menu.readthedocs.io). I am aware that doing type hints evaluation for list/tuple is only available for 3.9+.

JaskRendix commented 10 months ago

No benefit from what I know. No issue, I'm going to close.

ppizarror commented 10 months ago

Thanks! If you want to contribute, please feel free to do it. There are many challenges and things to improve, and your contributions are really appreciated to maintain this project.

Greetings 😄