pplans / foundry-vtt-module-motion-tracker

A module giving life to the Alien RPG motion tracker in foundry VTT
MIT License
6 stars 8 forks source link

Incompatiblility with v11 #56

Closed Txus5012 closed 1 year ago

Txus5012 commented 1 year ago

Hi. Great module. Thanks!

In Foundry v11 doesn't seem to work, looks like an issue with the new PIXI. Error

r-valyar commented 1 year ago

+1 to have this nice module updated to v11 if possible! :)

azarius74 commented 1 year ago

+1

Bekradan commented 1 year ago

+1

messiahcide commented 1 year ago

+1

Melkkart commented 1 year ago

+1

Keladryel commented 1 year ago

+1

CodaBool commented 1 year ago

@pplans do you plan on still maintaining this? I might have interest in forking if not.

CodaBool commented 1 year ago

have a working version. There are some console warnings about a sound file. I will try to resolve that but should be able to put out a PR to get this module fixed!

image

Bekradan commented 1 year ago

Fabulous.  Well,done.

Kind regards,Wayne

On Friday, September 1, 2023, 7:29 pm, CodaBool @.***> wrote:

have a working version. There are some console warnings about a sound file. I will try to resolve that but should be able to put out a PR to get this module fixed!

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

pplans commented 1 year ago

hi guys, yeah I plan to do so but have had troubles working on two parallel versions on my computer before and have no much time to digg it through. Am currently based on the stable version (10) until next release, you can make a PR I'll review it

pplans commented 1 year ago

Also, the sound file is an issue with the current state of the Foundry sound API which is kinda bad. I can't remember the details right now but it involved non cached memory for the sound boards, so each time you wanna play a sound it will try to load it. This process takes time and doesn't suit the sound for the motion tracker who needs high trigger precision

CodaBool commented 1 year ago

I have an implementation with AudioHelper, should have a PR out by end of today. We can discuss things once I have that made.

CodaBool commented 1 year ago

PR 🐱

pplans commented 1 year ago

PR is being reviewed, sorry for the delays, been sick & still at work :')

Mizy78 commented 1 year ago

How can I install a working v11 version?

CodaBool commented 1 year ago

best to just wait for the PR to get merged

...but if you are feeling impatient the extra bug testing might be useful.

requires git installed on your server

  1. install the v10 module
  2. go to modules folder on your server for me this is .../Data/modules/
  3. delete the motion_tracker folder
  4. clone my fork git clone https://github.com/CodaBool/motion_tracker.git
  5. make sure you have the module enabled and restart your server.
  6. :sunglasses: should be using a v11 working version

if you run into any issues with the v11 version it'd be useful to know on that pr I opened.

pplans commented 1 year ago

Hi guys, the v11 migration should be online, thanks CodaBool for his efforts. Please let me know if we can close the issue

rdefendi commented 1 year ago

On a quick check the audio volume controls and the checkbox to ignore PCs don't seem to work. Other than that, it's great to have this module back!

CodaBool commented 1 year ago

Awesome, glad it's mostly working. I know why both those bugs are happening. Those should be straightforward fixes. I could probably put out a PR before the end of the month for those.

pplans commented 1 year ago

ok so am closing this issue then, we can make a second for the checkbox