search

pplans / foundry-vtt-module-motion-tracker

A module giving life to the Alien RPG motion tracker in foundry VTT
MIT License
6 stars 8 forks source link

V12 compatibility fixes #79

Closed IcedEagle closed 5 months ago

IcedEagle commented 5 months ago

v12 completed a few v10 deprecations that broke the module, such as removing .data from some of the objects. I fixed it up enough where it seems like it's working again. Runs with no errors in console.

Tested audio, switching tokens, false signals and CRT static effect. Wasn't sure how the fast token or player disposition items worked, so couldn't verify those.

Some of the deprecations I found: https://github.com/foundryvtt/foundryvtt/issues/10164

IcedEagle commented 5 months ago

One thing not covered in my PR was any changes to the module.json itself. I'd assume this might work in v11, since the deprecation wasn't completed? But haven't tried it. And then if there was any checks you wanted to do before giving it the v12 verified stamp too.

pplans commented 5 months ago

Thanks man I appreciate this! I wanted to test everything then put you in the contributors! I'll do tomorrow morning these days have been a bit busier mentally than expected.

IcedEagle commented 5 months ago

Thanks man I appreciate this! I wanted to test everything then put you in the contributors! I'll do tomorrow morning these days have been a bit busier mentally than expected.

Take your time. Hope you're doing well!