search

pplu / aws-sdk-perl

A community AWS SDK for Perl Programmers
Other
171 stars 94 forks source link

Namespace collision for Paws::SQS::AttributeMap #25

Closed codehead closed 9 years ago

codehead commented 9 years ago

Both Paws::SQS::Message->Attributes and Paws::SQS::GetQueueAttributesResult->Attributes return a Paws::SQS::AttributeMap object. The first object should contain message attributes (e.g. SentTimestamp) and the second queue attributes (e.g. MessageRetentionPeriod). Just to add to the confusion, there's a Paws::SQS::MessageAttributeMap object for user-defined metadata, which works fine but is totally unrelated to either of these. I wonder what would be the best way to fix this without breaking the automagical object generation mojo.

pplu commented 9 years ago

I'm taking a look at it. Have to confirm if the definition files specify the same name, or if the autogeneration is just choosing the wrong names for the shapes :)

pplu commented 9 years ago

Can you tryout / verify if https://github.com/pplu/aws-sdk-perl/commit/ae3408485fd16c8455c22cc2372d53e5d71bf5c2 is correct? It looks like the botocore sqs definitions (checking out the master should give you that changeset)

codehead commented 9 years ago

Great, it certainly fixes the Queue side of the deal! I just did a PR to fix Paws::SQS::AttributeMap Thanks for the prompt action!

pplu commented 9 years ago

Paws 0.09 (released to CPAN today) has your changes applied :)