Open pplu opened 4 years ago
Great I will hold off doing anything more for RestXML calls until we get .44 out
Any timeframe on when the dates will be?
I think you can continue working, but I'd try to get in contact with @castaway to see how we can ease possible merge conflicts and what would be a good strategy for getting your worked merged with the least possible trauma. If we coordinate with @castaway, we'll be better off.
I promptly managed to have an annoying (headachey) cold the rest of the week.. Am back now.
The fun part is going to be merging the two chunks of code (shadowcat's tests/stabilisation, and byterock's s3objecttagging) which fix many of the same problems, likely in different ways. Most helpful would be if @byterock could concentrate on rebasing his branch off of stabilisation, and review the differences / extract out the unique bits.
Luckily SC didn't do any botocore updates, so we can probably take @byterock's botocore update as is (after @pplu has done whatever usual pulls to get the current state)
@pplu, while you're doing the 0.42 release, can you list the steps please? (unless they're already somewhere) .. an idea of when you'll get to it would also be handy ;)
Ok I will see if I can re-base
Not 100% sure how to do that on gitub exatly but will try.
But I think there be many more bugs I ran into and suished (fixed) as I went into each command in detail.
Remember I fixed up all the packages that used restXML some of them required changes that also changed how S3 to work.
I will thak your branch and run the 09 and 10 suites agains it and see what breaks.
Will give it a shot.
F-A-B.
Tis likely a rebase will be quite difficult to untangle, so maybe it is worth starting by moving all the tests over and seeing what's missing - then we'll need a branch with just those bits.
I'm reviewing open PRs as well:
@pplu, we left https://github.com/pplu/aws-sdk-perl/pull/276 open (I believe the actual code fixes are in tests/stabilisation), to discuss the communication around the changes. We should probably finalise that before 0.43
@byterock the branch/code we are starting with is in #265 - link: https://github.com/shadow-dot-cat/aws-sdk-perl/tree/tests/stabilisation
Ok I tried that branch eariler today. Could not get any of the new 09_requests.t and most of the 10_resposes.t test to run. Just fails. Not sure which boto you are using but I only get a very few tests to pass from any of the test suites.
I did compare RestXmlCaller.pm and RestXMLResponse.pm the are way to divergent to merge. Most likely after you get non S3 fixes for 0.43 in and out the door, the best path would be a simple replace of thoses two and the templates as well (lots of changes in there for RestXML) plus any new traits I had to create.
Anyway. You might want to hold of creating more tests for S3 and route53 I have them both fully covered. I can add in more tests to cover if need be.
Anyway hopefully we can have a release soon
TTFN
I would suggest trying it with your botocore, as I didn't change any.. It would be really useful to actually know what the Paws::Net::* changes are, since tests/stabilisation does fix a number of things you've also fixed. It feels daft to do them twice in possibly different ways
If you can't figure them out I'll need to poke at them one at a time.
Btw I will be poking around in your branch, and adding comments to things that confuse me, as I think it'll make it easier to discuss that way, hope that's ok
Poke away two sets of eyes are great. I did not spend any time refactoring anything.
As for Boto in the end I did not have to make any changes specific for RestXML. As I went along I found what I needed and changed the 'pm' and templates etc. There may be a few upper and lower case issues with I think 'S3Control' (API/Boto doc says one thing but the API fails on them, have a but up on boto for that
0.42 has just been uploaded to CPAN. @castaway: I merged in a fix basically due to a confusion, but since it was a very limited bug fix, I've left it in.
0.43 status: tests/stabilisation (and fix for #380) merged into release/0.43 branch - and passes Travis
I'm now thinking we do this as a DEV release, then add @byterock 's tests (and fixes for them), release that as DEV (with S3 warnings removed!), then the whole thing as an actual release.
NB: Since merging byterock's changes on top of ours was a bit of a mess (we'd both fixed the same things in different was, in some cases), I've grabbed the tests, and then imported the actual changes piecemeal (in some cases revising them), and shoved it here: https://github.com/pplu/aws-sdk-perl/tree/byterock_merge - This hasn't been rebased onto 0.43 yet! So add small pinch of salt.
I intended to make commits per fixed thing, but time (and maybe memory) got away.. and I wanted to store it in case it got lost.
Sounds like a good plan. I have been sidetracked these days with a trip the was planned and canceld but will have time to play over the next little while. I will have a look at that branch a get my real world tests to run against it.
By the way on the S3/Kinesis stream side of things I have that mostly worked out I was jsut holding off checking anyting in untill we get this major push done. I found a number of holes in the pagination in general that need to be plugged.
F.A.B.
Hi,
Just as a brief update on what the plan is for next releases, since I've been totally swamped and irresponsive:
0.42: Do a last update of services with last AWS definitions, so we have an updated Paws on CPAN - DONE 0.43: Merge stabilization branch 0.44: Merge @byterock changes and fixes 0.45: Mooification
Most of this work will be done by @castaway, which has recently been appointed as a member of what I'll call "Paws core team", as an effort to avoid Paws development not depending on a single person.
Thanks @byterock and @castaway for the efforts you've been going through. Hope that with this release plan we can get all your valuable contributions to CPAN.