pplude / TronScriptEvo

TRON Script: Evolution
MIT License
13 stars 1 forks source link

Missing command line switches #5

Closed nemchik closed 9 years ago

nemchik commented 9 years ago

Currently there are no command line switches available that would allow the script to run with different options or skip certain sections. There was a comment on reddit about an API and modularizing and making plugin hooks, which could replace the need for command line switches if done correctly (and made easy enough). If this is the route you decide to go the plugin hooks would allow you to change the code of the existing functions to skip or reconfigure how they behave.

For ease of mainline use though I do still think command line switches are a good idea, just to accommodate a quick difference in a run.

pplude commented 9 years ago

I have a plan for that, and I am playing with it in a test environment. I don't want to go into too much detail before I have a PoC working.

nemchik commented 9 years ago

Also by the way I think the outcome of resolving this issue could potentially make the CetraTron branch obsolete, because you could either use plugin code or command line switches, or whatever, to only run certain parts of the main script, which in essence would be equivalent to a slimmed down run (which is my understanding of your intentions with your CetraTron branch).

pplude commented 9 years ago

CentraTron is for use with our Remote Management and Monitoring platform, CentraStage. It's far easier to have that as a paired-down version that strips out what CentraStage already does for us there. Also, passing command line switches through the system is a PITA.

Don't worry about that branch too much, myself and others at my MSP are going to work on that. I need somewhere for it to be backed up that's not on my workstation.

pplude commented 9 years ago

One thing I am exploring at this point is a small XAML or WinForms GUI for the switches, disclaimer, etc. That's taking a little more time between my normal ticket loads.

nemchik commented 9 years ago

Understood, i'm in a similar boat, but my RMM (not CentraStage) can handle command line switches, so i'll end up using the full version, but pairing it down as you mentioned to avoid duplicate efforts from my RMM system.

staticextasy commented 9 years ago

I've created a sample of how paramaters work in my TestPhase branch. Is this what we're looking for?

the Param statement on Line 29 is how we accept args

They're boolean switches, so we would call Core.ps1 with PS ./Core -acceptEULA -skipAV and that would in turn skip both the EULA and the whole disinfect stage.

nemchik commented 9 years ago

I think this is a good start. Definitely has a lot of potential to make the runs pretty specific.

staticextasy commented 9 years ago

It'll take a lot to update all of the code with IF statements but this will give us the full potential of passing parameters to the very specifics of items.

pplude commented 9 years ago

Already merged a test for Kaspersky to the master about 4 hours ago. Good to know we are all on the same page

Sent by Outlook for Android

On Tue, Sep 8, 2015 at 6:47 PM -0700, "StaticExtasy" notifications@github.com wrote:

It'll take a lot to update all of the code with IF statements but this will give us the full potential of passing parameters to the very specifics of items.

— Reply to this email directly or view it on GitHub.

pplude commented 9 years ago

Switches have been added. Need someone good with XAML and .NET to do a GUI-fied version. The initial issue is resolved, and a feature request ticket can be opened for the new GUI.