search

ppodgorsek / docker-robot-framework

Robot Framework in Docker
https://cloud.docker.com/repository/docker/ppodgorsek/robot-framework
MIT License
340 stars 236 forks source link

issue #421: fix grep output to return number of lines #422

Closed dencze closed 1 year ago

dencze commented 2 years ago

if ROBOT_TEST_RUN_ID is set, the underlying script run-tests-in-virtual-screen.sh is not waroking as intended instead a warning is produced: /opt/robotframework/bin/run-tests-in-virtual-screen.sh: line 11: [: -eq: unary operator expected

Reason is, that operator -eq expects integer as variables. See abs for details.

This fix uses the count commandline parameter of grep to count the rows with trailing slash. The result is an integer, which can be used with -eq operator.

ppodgorsek commented 1 year ago

Hello @dencze , thank you for your contribution! Could you add more details in the PR description to explain why this change is required please?