search

ppodgorsek / docker-robot-framework

Robot Framework in Docker
https://cloud.docker.com/repository/docker/ppodgorsek/robot-framework
MIT License
346 stars 240 forks source link

Added Chrome for Testing instead of Chromium #485

Closed andy-kru closed 4 months ago

andy-kru commented 7 months ago

Added support for Chrome for Testing: https://developer.chrome.com/blog/chrome-for-testing It can potentially fix issues like https://github.com/ppodgorsek/docker-robot-framework/issues/482 due to better compatibility between ChromeDriver and Chrome for Testing.

andy-kru commented 7 months ago

@ppodgorsek I have updated the Firefox version to fix the build: https://github.com/andy-kru/docker-robot-framework/actions/runs/8723562158

ppodgorsek commented 4 months ago

Hello @andy-kru, thank you very much for your contribution! Sorry for the delay in getting back to you, I had to take care of some personal stuff for the last few months.

I agree with you, the branded Chrome is the browser end users rely on rather than Chromium, tests would be more accurate with it.

I've updated most dependency versions of the project today, I'll take care of your PR tomorrow.

ppodgorsek commented 4 months ago

The PR has slightly simplified and merged. Thanks again for your help, @andy-kru !