search

ppoffice / hexo-component-inferno

A collection of Inferno.js layout components and utility scripts for Hexo
https://ppoffice.github.io/hexo-component-inferno/
25 stars 30 forks source link

External Links bug, unable to render url AND hide hostname with Icarus #58

Closed vishvish closed 1 year ago

vishvish commented 1 year ago

Based on docs found here: https://ppoffice.github.io/hexo-component-inferno/module-view_widget_links-Links.html

Using the following YAML in _config.icarus.yml

    links:
      Link Name 1: /path/to/external/site
      Link Name 2:
        link: /path/to/external/site
        hide_hostname: true

The first link renders correctly.

The second link displays the name, and hides the space for the hostname, but does not render the hostname within the link so there is no link.

image
ppoffice commented 1 year ago

I don't see a problem here. Hide hostname means that it will not be rendered.

vishvish commented 1 year ago

The URL link doesn't work - it's not rendering the hostname URL within the link <a href="xxx>

i.e. the link is not link, it's just a name.

ppoffice commented 1 year ago

@vishvish Thank you for pointing it out. The bug is fixed in the latest commit.

vishvish commented 1 year ago

Awesome, thanks @ppoffice - I tried to find the bug and patch my own library, bit couldn't!