search

ppoffice / hexo-theme-hueman

A redesign of Alx's wordpress theme Hueman, ported to Hexo.
http://ppoffice.github.io/hexo-theme-hueman/
GNU General Public License v2.0
1.17k stars 336 forks source link

Add some optional configuration settings for isso. #225

Closed theKidOfArcrania closed 6 years ago

theKidOfArcrania commented 6 years ago

Better configurations for isso comments.

I'm not sure if there is any coding conventions/style/testing that needs to be done before merging. If there is, let me know and I will fix it.

ppoffice commented 6 years ago

@theKidOfArcrania Thank you for your contribution. I think you need to clean up and format the statcounter code. Also, please be careful inserting elements after the footer section because if you do that, the element will be outside of the layout.

theKidOfArcrania commented 6 years ago

Heh.. I was in a rush to commit statcounter code (and that was the exact code that statcounter gave me). Also, actually I think it was originally installed in the head, not even after the footer area (was not aware of the file structure initially). I will fix it very soon.

theKidOfArcrania commented 6 years ago

Code should be fixed up, although I'm not entirely sure if emitting a deprecation warning (when a string value is supplied to comment.isso) using console.warn is the best approach. Oh well, if you have any better suggestions let me know.