ppolabs / jlinda

jLinda - Java Library for Interferometric Data Analysis
9 stars 5 forks source link

Artifacts in Simulated TOPO phase #15

Closed pmar closed 10 years ago

pmar commented 11 years ago

@AndreaMinchella reported that in some cases artifacts in simulated topographic phase can be observed, as marked in the attachment: rsat2_srd_topo_issue

Note: This problem exposes rarely, and it is rather exception than rule.

pmar commented 11 years ago

Status: Confirmed

The problem is in how the tile extents are being computed. This will be fixed in v0.7.

Context:

These tile extents are need to be able to complete cover the SAR tile with input DEM tile. Note, that we are mapping (DEM in WGS84 Geometry in DEM Sampling) -> (DEM SAR Geometry in DEM Sampling) -> (DEM SAR Geometry SAR Sampling).

This tile extent is computed dynamically, not to overhead too much processing of tiles that do not need large extent. For this dynamic computation of the approx max height of the tile is performed -- grid of X points distributed, and search for max heights. However, this might not be robust enough for every and any case study. Especially, if there is strong slope at the edges of the tile, or lot of height difference between tile edges.

Fixes ideas:


pmar commented 10 years ago

Update:

Quick and dirty fix 3 is implemented, and it is under evaluation.

pmar commented 10 years ago

Resolved with: 1b1f8d63b1294a1e54243ad2107334e289e3afb9. All test pass.


For disclosure and completeness, also attached screenshots of 'before' vs 'after' results. Results with artifacts and without artifacts, as a result of the fix. The input for both results is exactly the same data set.

Note histogram values, and smoothness of the signal.

Before fix


before

After fix


after

pmar commented 10 years ago

Reopening because the implemented fix https://github.com/ppolabs/jlinda/commit/1b1f8d63b1294a1e54243ad2107334e289e3afb9 degrades the performance.

Depending, on the area the slow-down of couple of orders is observed.

pmar commented 10 years ago

Solution to be implemented: