search

ppp-project / ppp

Paul's PPP Package: PPP daemon and associated utilities | Official GitHub repo: https://github.com/ppp-project/ppp
https://github.com/ppp-project/ppp
Other
390 stars 231 forks source link

--disable-microsoft-extensions requires --disable-peap #433

Open willyamcts opened 1 year ago

willyamcts commented 1 year ago

When disable Microsoft Extension is required disable PEAP, both are not dependent correct?

if not using --disable-peap the error happens in compilation:

# ./autogen.sh --prefix=/usr/local/pppd --disable-microsoft-extensions

peap.c: In function ‘peap_init’:
peap.c:522:12: error: ‘struct peap_state’ has no member named ‘chap’
  522 |         psm->chap = chap_find_digest(CHAP_MICROSOFT_V2);
      |            ^~
make[2]: *** [Makefile:1492: pppd-peap.o] Error 1
Neustradamus commented 1 year ago

@paulusmack, @enaess: Have you seen this ticket?

enaess commented 1 year ago

Right now, the only peap method supported is mschapv2, so yes they are sort of dependent on each other. Technically, in the future they can be disjoint...

Neustradamus commented 1 year ago

@enaess: Can you look it?

Neustradamus commented 3 months ago

@enaess: Have you progressed on it?

enaess commented 3 months ago

No progress, we can still ship 2.5.1 without this. People would just need to know, PEAP with CHAPv2 is the only thing that woks right now, and if you disable the CHAP extension, PEAP won't authenticate. However, in the future you could probably use PEAP-PAP or something there alike.

paulusmack commented 3 months ago

I should add a note to the README about this.