search

ppp-project / ppp

Paul's PPP Package: PPP daemon and associated utilities | Official GitHub repo: https://github.com/ppp-project/ppp
https://github.com/ppp-project/ppp
Other
384 stars 231 forks source link

Configuring with --enable-microsoft-extensions=no breaks the compile #523

Open paulusmack opened 3 weeks ago

paulusmack commented 3 weeks ago

After configuring with --enable-microsoft-extensions=no, running make gives:

  CC       pppd-peap.o
peap.c: In function ‘peap_init’:
peap.c:522:12: error: ‘struct peap_state’ has no member named ‘chap’
  522 |         psm->chap = chap_find_digest(CHAP_MICROSOFT_V2);
      |            ^~
make[2]: *** [Makefile:1520: pppd-peap.o] Error 1

@enaess ?

Neustradamus commented 2 weeks ago

@enaess: Have you seen this @paulusmack ticket?

enaess commented 1 week ago

If you disable Microsoft extensions then you might as well disable peap in the configuration too. Mschap is the only working peap method at this point.

paulusmack commented 1 week ago

So then we should make peap depend on ms-extensions at the configure stage...

enaess commented 1 week ago

@paulusmack for the time being, I think that would be appropriate. There might be a time in the future someone would add e.g. PEAP-SHA1 or something similar, which should allow configuring PEAP with whatever it supports. But since MsChapv2 is the only supported PEAP mechanisms now, then yes ...

Neustradamus commented 1 week ago

Hope it can be added before a 2.5.1.1 or 2.5.2 release :)