search

ppresume / community

Discussions, feedbacks, roadmaps, community for PPResume.
https://blog.ppresume.com
Creative Commons Attribution 4.0 International
86 stars 3 forks source link

bug: placeholder in text editor will display out of the SectionShell when page is loading #102

Closed xiaohanyu closed 2 months ago

xiaohanyu commented 2 months ago

Description

The text editor's placeholder will be displayer out of the loader when the resume page is loaded. Root cause is that we havn't set a min-height for text editor, so when the page is loading, the content of the text editor is empty, leading to a overflow of the text editor.

To Reproduce

  1. Go to a resume form page
  2. Reload the page

Actual Behavior

The placeholder in basic seciont's will display out of the loading overlay box, which is a overflow.

https://github.com/user-attachments/assets/8dd99b54-3144-4275-87c5-ee6b69202410

Expected Behavior

The SectionShell's loading overlay should cover the whole section, including the text editor.

[Optional] Screenshots

NA

Additional Context

NA

xiaohanyu commented 2 months ago

Fixed, preview:

https://github.com/user-attachments/assets/d5c27ddf-f40c-43de-8a78-4356cb5d6f81

xiaohanyu commented 1 month ago

Got a gap after setting min-height:

image

Fixed.