ppresume / community

Discussions, feedbacks, roadmaps, community.
57 stars 3 forks source link

bug: fix <LoadingOverlay>'s height in `/dashboard` page #29

Closed xiaohanyu closed 5 months ago

xiaohanyu commented 5 months ago

Description

The current height settings for <LoadingOverlay> in /dashboard page is not not right, i.e, the height is equals to the height of tab panel's body, while ideally it should be almost equals to calc(100vh - distance between top edge of tab panel body and html root <body>).

Check the following screenshot and you will see why we need this fix.

Image

[Optional] Possible Solutions

NA

Acceptance Criteria

Todo list

NA

xiaohanyu commented 5 months ago

Fixed:

Image

On mobile:

https://github.com/ppresume/community/assets/1164623/f6f5b0df-765f-496c-87cd-46de63f49890