search

ppresume / community

Discussions, feedbacks, roadmaps, community.
60 stars 3 forks source link

bug: sanitize username with special characters #30

Closed xiaohanyu closed 7 months ago

xiaohanyu commented 7 months ago

Description

When username contains special chars like ., -, '/, PPResume would fail to generate and set a valid logto username as logto do not allow special chars (with_` as the only exception) as part of the username.

To Reproduce

Steps to reproduce the behavior:

  1. Register a new account with email like a.b@xxx.com
  2. Check whether the new account has a valid username

Actual Behavior

The new registered account would have null username

Expected Behavior

The new registered account should have a sanitized username as well.

[Optional] Screenshots

NA

Additional Context

This is a similar bug to https://github.com/ppresume/ppresume/issues/166

xiaohanyu commented 7 months ago

Done.

We also revised the style for username in /settings page:

Image