feat: conform PPResume to PWA Builder stage 1

ppresume / community

Discussions, feedbacks, roadmaps, community.

57 stars 3 forks source link

feat: conform PPResume to PWA Builder stage 1 #47

Closed xiaohanyu closed 2 months ago

xiaohanyu commented 2 months ago

Description

PWA Builder showed us a list of suggestions to further improve PPResume's manifest. Let's revise the manifest to conform PPResume to PWA Builder's suggestions as much as possible.

[Optional] Possible Solutions

Acceptance Criteria

try best to conform PWA Builder's manifest checker's suggestions

Todo list

xiaohanyu commented 2 months ago

If theme_color is not specified, chrome and edge would show different font color.

Chrome:

light mode:
dark mode:

Edge:

light mode:
dark mode:

And theme_color do not support dark/light mode switch yet, check this issue

It seems possible to change theme_color dynamically via JavaScript, though.

xiaohanyu commented 2 months ago

Before fix we have 15 warnings, after fix we have 8 warnings, we will create other issues to further improve PPResume PWA