Elixir 1.3 / OTP 19 compatibility

jwarlander commented 8 years ago

The change is tested locally by me, as I was getting IElixir to work -- but unfortunately it introduces an error in one of the doctests (lib/ielixir/sandbox.ex:102):

      iex> IElixir.Sandbox.execute_code(%{"code" => "\"a\" + 5"})
      {:error, "ArithmeticError", ["** %ArithmeticError{}"]}

..where the error output is apparently more detailed in Elixir 1.3:

  1) test doc at IElixir.Sandbox.execute_code/1 (6) (SandboxTest)
     test/sandbox_test.exs:5
     Doctest failed
     code: IElixir.Sandbox.execute_code(%{"code" => "\"a\" + 5"}) === {:error, "ArithmeticError", ["** %ArithmeticError{}"]}
     lhs:  {:error, "ArithmeticError",
            ["** %ArithmeticError{message: \"bad argument in arithmetic expression\"}"]}
     stacktrace:
       lib/ielixir/sandbox.ex:102: IElixir.Sandbox (module)

I'm not sure of the best way to resolve this; if I change it, then it'll fail in earlier Elixir versions instead.

coveralls commented 8 years ago

Coverage remained the same at 46.97% when pulling abbea748aab30b472cbc79402cb0758e4a820bfb on jwarlander:elixir-1.3-compat into ed3808c82be5377c33d379ba272508fa5743ab13 on pprzetacznik:master.

jwarlander commented 8 years ago

Sorry, had to push these commits again w/ correct email address :)

coveralls commented 8 years ago

Coverage remained the same at 46.97% when pulling dfbda64b317cf82d1743000944d442b26a6bf5a2 on jwarlander:elixir-1.3-compat into ed3808c82be5377c33d379ba272508fa5743ab13 on pprzetacznik:master.

pprzetacznik commented 8 years ago

@jwarlander Thanks for that!

I think it's ok to abandon support for older OTP versions, I will try to rewrite this example but I cannot ensure that we can do that forever.

pprzetacznik / IElixir

Elixir 1.3 / OTP 19 compatibility #15