search

pprzetacznik / IElixir

Jupyter's kernel for Elixir programming language
Apache License 2.0
359 stars 42 forks source link

Support stderr #41

Closed pragdave closed 6 years ago

pragdave commented 6 years ago

Refactored the capture code, so we now grab stderr and stdout, passing stderr back to Juptyer in a separate stream.

Unfortunately, as a PR, this change relies on the additional refactorings done when adding HTML support, so you probably want to merge that one first.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-4.3%) to 57.143% when pulling f854674756305e7f5dcf9f447dca7a47c06dde4e on pragdave:support-stderr into 8053ae32528f540188b5ba9e090464cd68480ce4 on pprzetacznik:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-4.3%) to 57.143% when pulling f854674756305e7f5dcf9f447dca7a47c06dde4e on pragdave:support-stderr into 8053ae32528f540188b5ba9e090464cd68480ce4 on pprzetacznik:master.

pprzetacznik commented 6 years ago

@pragdave Thanks for your input Dave! I will need some time to read all of this :)

pragdave commented 6 years ago

Yeah, sorry about that. I had to refactor a little to keep the code under control.