search

pprzetacznik / IElixir

Jupyter's kernel for Elixir programming language
Apache License 2.0
359 stars 42 forks source link

Feature/erlzmq hex and fix decimal erlang 20 #48

Closed ghost closed 5 years ago

ghost commented 5 years ago

upgraded/fixed version of erlzmq (rebar3) from hex and upgraded decimal to 1.7.0 (and added override) in order to fix build on erl 20/elixir 1.8.2

ghost commented 5 years ago

Yeah - the erlzmq2 package was doing some really unpleasant things like downloading an ancient version of the zmq source code as part of it's build, relied on a Makefile, relied on the old rebar, had problems building IElixir and just decided to pull the whole thing apart.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.3%) to 50.746% when pulling 920dc0d59f5dd9072500bb2360ed3ca779c943b7 on bryanhuntesl:feature/erlzmq-hex-and-fix-decimal-erlang-20 into 3d28737dfafb4f2f3cb3c2ed4f0185dd605d14cf on pprzetacznik:master.

ghost commented 5 years ago

Coveralls report is incorrect - I don't know how coverage could have decreased - I haven't modified any of the source code - just changed a dependency and updated the README.

ghost commented 5 years ago

You like ?

pprzetacznik commented 5 years ago

@bryanhuntesl thanks for you input. Do you know exactly why decimal override is necessary here?

pprzetacznik commented 5 years ago

@bryanhuntesl I see there were problem with Boyle's test that can be fixed with adding app: false to in that test. Do you see any else issue with decimal?

ghost commented 5 years ago

@bryanhuntesl I see there were problem with Boyle's test that can be fixed with adding app: false to in that test. Do you see any else issue with decimal?

Setting app: false should be sufficient thanks @pprzetacznik - I was thinking of upgrading SQLite to ecto 3 next - would you be interested in a pr for that?

ghost commented 5 years ago

Thanks @pprzetacznik

pprzetacznik commented 5 years ago

I was looking for a bug on a branch commit, it took me a while. Now your changes are again on master. I've also upgraded sqlite to ecto 3.

Thanks for your input!

ghost commented 5 years ago

I was looking for a bug on a branch commit, it took me a while. Now your changes are again on master. I've also upgraded sqlite to ecto 3.

Thanks for your input!

Excellent. My pleasure.