search

pprzetacznik / IElixir

Jupyter's kernel for Elixir programming language
Apache License 2.0
357 stars 44 forks source link

Fix IElixir Jupyter Kernel crashes (IEx 1.14.0 / Erlang/OTP 25) #62

Closed JonathanxD closed 6 months ago

JonathanxD commented 1 year ago

I think #60 did exactly the same except for the tests and API call updates, but the PR was closed.

I've also updated sandbox to use elixir_erl_var.from_env instead of the removed elixir_env.env_to_scope call, and fixed some tests.

All tests passing but one, which complains about undefined symbol: cblas_sgemm and I didn't wanted to spend more time trying to figure out which library does have this symbol given that matrex seems to be not in active development.

Also a final disclaimer: I'm not an Elixir dev (that's my first time even touching Elixir code), I just wanted to get Elixir working on my Jupyter Notebook to do some experiments and those minor changes did fixed the kernel crashes and it does execute basic scenarios, but I'm pretty sure there are still broken bits (like Matrex).

pprzetacznik commented 7 months ago

Hey @JonathanxD,

thank you very much for the contribution. I was trying to refresh a little bit IElixir, however there were few dependencies, including erlzmq that were quite serious in amount of changes needed. I'll try to test your changes on my local as fast, as I'll find some time.

Thanks once again, Piotr

pprzetacznik commented 6 months ago

I've pulled the changes from this PR into another PR - https://github.com/pprzetacznik/IElixir/pull/64 Thanks for the contribution! It really helped me refresh the codebase! 🚀