search

ppsp-team / HyPyP

The Hyperscanning Python Pipeline
BSD 3-Clause "New" or "Revised" License
75 stars 42 forks source link

Partial directed coherence #40

Closed sofievettori closed 2 years ago

sofievettori commented 3 years ago

In the paper is mentioned that directed measures of causality or information transfer are implemented. But it doesn't seem to be in the source code of the current version. Is there a newer version available with it implemented? Or do you know when it will be available? thank you!

deep-introspection commented 3 years ago

For now, the PDC is not supported but we hope to implement it for the upcoming Beta release. If you are willing to help, do not hesitate to propose a python implementation that we can insert in the relevant function: i.e. https://github.com/ppsp-team/HyPyP/blob/master/hypyp/analyses.py#L391 (ping @phoebsc!)

deep-introspection commented 3 years ago

Maybe the MNE team has already found out a good way to get PDC: https://gist.github.com/agramfort/9875439

AmirDJV commented 3 years ago

Going over MNE's issue, it seems like at some point they wanted to compare it to SCoT's PDC function. From what I understand they did some testings for both functions. It might be interesting to see if the results are the same and under different conditions. If they are, to go with the easier implantation and benchmark. What to do you think?

deep-introspection commented 3 years ago

@phoebsc, we just had a nice pull request from @ghazalehran! Can you please double-check her proposal?