search

ppsp-team / PyNM

Lightweight Python implementation of Normative Modelling
BSD 3-Clause "New" or "Revised" License
30 stars 12 forks source link

nilearn missing from requirements.txt #26

Closed saigerutherford closed 2 years ago

saigerutherford commented 2 years ago

Re: JOSS review functionality

When running the tutorials, I get an error in tutorials 5-model_selection.ipynb and 6-downstream_analysis.ipynb because nilearn is not installed in the virtual environment. Please add nilearn to requirements.txt.

harveyaa commented 2 years ago

Hi @saigerutherford, nilearn is only used in that tutorial as a part of example usage of pynm and isn't required for the package itself. In order to keep the package lightweight I added notebook cells to the relevant tutorials with a note about nilearn installation and the code to do so on the spot rather than putting nilearn in the requirements.txt.