search

ppy / SDL3-CS

MIT License
45 stars 11 forks source link

Update SDL to pull in android enter key fix #167

Closed bdach closed 1 month ago

bdach commented 1 month ago

Update SDL submodule

Pulls in https://github.com/libsdl-org/SDL/pull/11256 to fix https://github.com/ppy/osu/issues/28966.

Fix linux-arm build failures due to docker changes

linux-arm(64) builds started failing with

latest: Pulling from arm64v8/ubuntu
docker: no matching manifest for linux/amd64 in the manifest list entries.

Upon closer inspection, new arm32v7/ubuntu and arm64v8/ubuntu images were pushed on Oct 19, 2024, which seemed related.

While pinning the images to the last known working digest worked, it's obviously suboptimal. Looking closer at previous passing build logs, warnings are noticeable:

WARNING: The requested image's platform (linux/arm/v7) does not match the detected host platform (linux/amd64/v3) and no specific platform was requested

WARNING: The requested image's platform (linux/arm64/v8) does not match the detected host platform (linux/amd64/v3) and no specific platform was requested

therefore I decided to try specifying the platform explicitly to see if it fixes the issue, and it does.

Native build workflow run result available for preview at https://github.com/bdach/SDL3-CS/actions/runs/11455020110.

Binaries available for testing at https://github.com/bdach/SDL3-CS/pull/19.

bdach commented 1 month ago

Will need someone with perms to run the build workflow at some point now.

smoogipoo commented 1 month ago

We need to check bindings before merging. Although SDL3 should be "api stable"...

smoogipoo commented 1 month ago

@Susko3 can you check the bindings here? haven't got a setup to easily generate them ;_; (+ OS differences - we really need https://github.com/ppy/SDL3-CS/issues/144)

🙏

Susko3 commented 1 month ago

Bindgen updated in #168. For future reference, there was no need to cancel the build native workflow before generating bindings since they're built off the same SDL commit.