ppy / osu-api

Public API for accessing osu! related data.
320 stars 16 forks source link

Missing expanded difficulty data #252

Closed CptHampton closed 5 years ago

CptHampton commented 5 years ago

This map https://osu.ppy.sh/beatmapsets/144171#osu/378344 doesn't return the new aim, speed, and strain difficulties added to /get_beatmaps

Magnus-Cosmos commented 5 years ago

Noticed a similar problem, this entire beatmapset https://osu.ppy.sh/s/106443 has null for diff_strain

Also, on the beatmap you linked, a large amount of scores on the leaderboard return null pp values

GrilledCheeese commented 5 years ago

This map has None/null values for difficultyrating and diff_speed: https://osu.ppy.sh/beatmapsets/937970#fruits/1962371 When using /get_beatmaps

GrilledCheeese commented 5 years ago

This LOVED beatmap gives None value for pp instead of 0: https://osu.ppy.sh/beatmapsets/375956#osu/823257 When using /get_scores

doughn0 commented 5 years ago

I have noticed that a lot of map_data(max_combo, diff_aim, diff_speed, difficultyrating) becomes null when requested with mods that don't change the difficulty, like HD or SD. This happened for me even on ranked maps. Look at this for example.

Magnus-Cosmos commented 5 years ago

Yeah, I tested mods as well and the only mods that work are HR, EZ, DT, and HT (and obviously combining HR with EZ or DT with HT will result in null values)

My suggestion for this would be to make it so that all the other mods should have no effect on the values rather than making the values null

ThePooN commented 5 years ago

@doughn0's issue is different and was already addressed by peppy here: https://github.com/ppy/osu-api/issues/126#issuecomment-489489817 You can refer to how I handled this issue here: https://github.com/ThePooN/nodesu/blob/6ce855ad1733df5042a3c430c3bd7afefef3f9a2/lib/components/BeatmapsComponent.js#L29

doughn0 commented 5 years ago

Oh I see, thanks.

peppy commented 5 years ago

Closing as intended behaviour (maybe update the wiki documentation mentioning this?)