ppy / osu-api

Public API for accessing osu! related data.
320 stars 16 forks source link

max_combo null on all taiko and mania maps #266

Closed jxu closed 1 year ago

jxu commented 5 years ago

To see: try any taiko or mania map. Example

{"beatmapset_id":"956145","beatmap_id":"1997319","approved":"1","total_length":"83","hit_length":"80","version":"Kuron's Oni Com Grave","file_md5":"3d9a66d052169b7af72e1d587ac3f594","diff_size":"2","diff_overall":"5","diff_approach":"0","diff_drain":"5","mode":"1","count_normal":"225","count_slider":"0","count_spinner":"1","submit_date":"2019-04-14 21:01:27","approved_date":"2019-06-01 04:00:02","last_update":"2019-05-24 12:30:42","artist":"MC L Da Vinte e MC Gury","title":"Parado no Bailao | Com Grave","creator":"Trynna","creator_id":"2652951","bpm":"130","source":"","tags":"net0 near kuron-kun kalindraz edu brazillian portuguese funk senhor srskyplayer cut short version mandstoledo mandela (bass boosted) (com grave) detona","genre_id":"7","language_id":"1","favourite_count":"43","rating":"8.53416","download_unavailable":"0","audio_unavailable":"0","playcount":"1116","passcount":"243","max_combo":null,"diff_aim":null,"diff_speed":null,"difficultyrating":"3.1174302101135254"},

could be #130 but I am using all ranked/loved maps

NoelleTGS commented 1 year ago

Any update on this? It's still happening

peppy commented 1 year ago

@NoelleTGS can you share the query you're using to see the issue?

peppy commented 1 year ago

I've tested the original beatmap in this thread and it works as expected. We've checked the code and database and both look correctly implemented. I'm going to close pending further details.

NoelleTGS commented 1 year ago

Sorry for late response. Might have just been a quirk of getting the beatmap through a score, because getting the beatmap normally returns it properly.