search

ppy / osu-api

Public API for accessing osu! related data.
321 stars 16 forks source link

get_replay by score id #297

Closed tybug closed 4 years ago

tybug commented 4 years ago

would be nice to be able to retrieve replay data from a replay id through the api. I know there's http://osu.ppy.sh/scores/osu/SCORE_ID/download, but unsure if that's the approved way to automatically download replays.

peppy commented 4 years ago

I've added this, via s parameter. Note you will still need to provide the game mode via m.

tybug commented 4 years ago

Thanks. Documentation added.

Any reason we can't download replays by restricted users? You can still do so through the website url /scores/osu, but not through this api call. For instance, https://osu.ppy.sh/scores/osu/2995111371/download vs https://osu.ppy.sh/api/get_replay?k=KEY&s=2995111371&m=0. Replay download links from this osureport thread on a recently restricted user.

peppy commented 4 years ago

that is actually a bug. they should not be available. will look into fixing

ThePooN commented 4 years ago

Sounds lame to me. Post-restriction replay analysis can still be useful.

tybug commented 4 years ago

I agree. Was hesitant to bring it up here for fear of this exact scenario. It has been tremendously useful to be able to look at month or year old osureport threads and download and analyze the replays — it is often the very fact that their player got restricted that makes a replay worth looking at.

peppy commented 4 years ago

Will discuss this internally. Maybe it's fine if it's API-level. The main thing is we don't want restricted users getting undue attention for breaking the game (becaues there is an audience for that kind of thing, unfortunately).

peppy commented 4 years ago

I've allowed getting such replays from apiv1 via score_id (only). We'll keep it this way for the time being.

tybug commented 4 years ago

I appreciate it!

On Thu, Feb 20, 2020 at 10:39 PM Dean Herbert notifications@github.com wrote:

I've allowed getting such replays from apiv1 via score_id (only). We'll keep it this way for the time being.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ppy/osu-api/issues/297?email_source=notifications&email_token=AHRJW3333JST47TN2RGF4YTRD5EH7A5CNFSM4KSPT7YKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMRM3FQ#issuecomment-589483414, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHRJW37IIVSLRM536Z2EXH3RD5EH7ANCNFSM4KSPT7YA .