search

ppy / osu-api

Public API for accessing osu! related data.
320 stars 16 forks source link

/get_user_best returns 'X' instead of 'SSH' in rank field #313

Closed blinchk closed 3 years ago

blinchk commented 3 years ago

So, I have a next request (limit 3, my username at osu! and standard mode) and response. image

On line 36 of response instead of rank 'SSH' returns 'X'.

tybug commented 3 years ago

I can't find where this is documented, but I'm pretty sure this is intentional. From osu-lazer (https://github.com/ppy/osu/blob/master/osu.Game/Scoring/ScoreRank.cs):

        [Description(@"S")]
        S,

        [Description(@"S+")]
        SH,

        [Description(@"SS")]
        X,

        [Description(@"SS+")]
        XH,

SS is X and SSH is XH.

blinchk commented 3 years ago

@tybug, thank you for answer!