search

ppy / osu-deploy

Deploy script for lazer
MIT License
46 stars 32 forks source link

Fix ugly installer splash screen #173

Closed smallketchup82 closed 3 weeks ago

smallketchup82 commented 3 weeks ago

Related: https://github.com/ppy/osu/pull/29773

Turns out that Velopack doesn't support transparent .png's as the splashicon, leading to issues like this on installation: image

Velopack supports a:

This PR reuses https://github.com/ppy/osu/blob/master/osu.iOS/Assets.xcassets/AppIcon.appiconset/300076680-5cbe0121-ed68-414f-9ddc-dd993ac97e62.png for the icon. Though, alternative designs are welcome.

Preview: image You can use this release to test it (you must not have lazer installed first)

Testing Checklist

smallketchup82 commented 3 weeks ago

Moved the file into osu-deploy. Not sure if we want it in an assets folder or not, but seeing as install.ico is in the root folder, I decided to place the splash image in the root folder as well. Let me know if you have another location in mind.

I'm still yet to test these changes, so I'll keep this PR as a draft until I do.

peppy commented 3 weeks ago

Looks blurry to me:

Jump Desktop 2024-09-12 at 05 41 31

peppy commented 3 weeks ago

It seems velopack doesn't handle high dpi displays correctly for the splash icon.

alexoshowo commented 1 hour ago

idk if i can place ideas out here, like in previous now closed pr, but if i can, i suggest to show some kind of artwork or something

peppy commented 1 hour ago

That's what I was hoping for. Just need to decide on the artwork.