Stencil isn't working on Veldrid renderers

ppy / osu-framework

A game framework written with osu! in mind.

MIT License

1.64k stars 409 forks source link

Stencil isn't working on Veldrid renderers #5858

Open EVAST9919 opened 1 year ago

EVAST9919 commented 1 year ago

OpenGL/LegacyGL	D3D

frenzibyte commented 1 year ago

This is also the case on Metal, it shows white circles instead. To start off: https://github.com/ppy/osu-framework/blob/9df4c9e418ebaa10ecdee98e07e4abaa83fbb49f/osu.Framework/Graphics/Veldrid/VeldridRenderer.cs#L98

This line doesn't specify a stencil attachment, it should be changed to D24_UNorm_S8_UInt or D32_Float_S8_UInt (note the former isn't supported on all Metal GPUs).