ppy / osu-framework

A game framework written with osu! in mind.
MIT License
1.67k stars 419 forks source link

Expose `LocalisationManager.GetLocalisedString()` as public #6377

Closed bdach closed 2 months ago

bdach commented 2 months ago

The initial rationale for it being internal was likely that there was never going to be any meaningful external usage of it, but as it turns out, there are cases where you want this, one of them being https://github.com/ppy/osu/pull/29913 - without having the non-bindable variant exposed, weird games of taking out the bindable and then manually unbinding it immediately after use have to be played to avoid reference leaks.

The pre-existing xmldoc should do the job when it comes to warning users that the method will likely not do what they want it to in most cases.