ppy / osu-framework

A game framework written with osu! in mind.
MIT License
1.67k stars 419 forks source link

Fix DecouplingFramedClock retaining old lastSeekFailed #6378

Closed hwsmm closed 2 months ago

hwsmm commented 2 months ago

This PR fixes an issue where DecouplingFramedClock retains old lastSeekFailed after changing its source.

It only happens on Windows because it only has platform offset due to new BASS versions. Seeking to 0 in EditorClock is practically seeking to -15, so TrackVirtual fails to seek to negative position, which in turn sets lastSeekFailed to true, but DecouplingFramedClock doesn't reset the variable after changing the source, so it just keeps interpolating instead of actually playing the source.